[webkit-reviews] review granted: [Bug 72723] [CSS Filters] WebKit crashes when changing the filter : [Attachment 115802] Patch V1

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 72723: [CSS Filters] WebKit crashes when changing the filter
https://bugs.webkit.org/show_bug.cgi?id=72723

Attachment 115802: Patch V1
https://bugs.webkit.org/attachment.cgi?id=115802&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115802&action=review


> LayoutTests/css3/filters/crash-filter-change.html:7
> +<img style="-webkit-filter: hue-rotate(90deg)"
src="resources/reference.png">
> +<script>
> +    // force a layout
> +    document.body.offsetTop;
> +    var img = document.getElementsByTagName('img')[0];
> +    img.style['-webkit-filter'] = 'hue-rotate(10deg)';

Why not use CSS classes and change the className?

> Source/WebCore/rendering/FilterEffectRenderer.cpp:238
> +    setMaxEffectRects(m_sourceDrawingRegion);

Could this be tested separately? Does the right thing happen if the size of the
filtered element changes?