[webkit-reviews] review granted: [Bug 72621] Web Inspector: dispatch messages from the front-end to the backend asynchronously. : [Attachment 115786] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 72621: Web Inspector: dispatch messages from the front-end to the backend
asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=72621

Attachment 115786: Patch
https://bugs.webkit.org/attachment.cgi?id=115786&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115786&action=review


> Source/WebCore/inspector/InspectorConsoleAgent.cpp:138
> +    m_inspectorState->setBoolean(ConsoleAgentState::consoleMessagesEnabled,
false);

It looks like we may clear inspector state once when front-end is disconnecting
instead of spreading this logic over individual agents.

> Source/WebCore/inspector/InspectorFrontendClientLocal.cpp:83
> +	      
m_inspectorController->dispatchMessageFromFrontend(m_messages.takeFirst());

Please add a comment here that this task may be already destroyed after
dispatchMessageFromFrontend call.