[webkit-reviews] review granted: [Bug 45955] Web Inspector: [Extensions API] Provide a way for extension to create a status bar icon : [Attachment 115758] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 18 01:59:49 PST 2011


Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 45955: Web Inspector: [Extensions API] Provide a way for extension to
create a status bar icon
https://bugs.webkit.org/show_bug.cgi?id=45955

Attachment 115758: Patch
https://bugs.webkit.org/attachment.cgi?id=115758&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115758&action=review


> Source/WebCore/ChangeLog:3
> +	   Web Inspector: [Extensions API] Provide a way for extension to
create a status bar icon

status bar button?

> Source/WebCore/inspector/front-end/ExtensionPanel.js:114
> +    this._statusBarItems = [];

statusBarButtons ?

> Source/WebCore/inspector/front-end/ExtensionPanel.js:199
> +	* @param {?string} iconURL

Are these nullable or optional?


More information about the webkit-reviews mailing list