[webkit-reviews] review denied: [Bug 72155] Replace Qt QThread threading back-end with pthread/Win32 threading back-ends : [Attachment 114751] use native threading back-end

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Andrew Wason
<rectalogic at rectalogic.com>'s request for review:
Bug 72155: Replace Qt QThread threading back-end with pthread/Win32 threading
back-ends
https://bugs.webkit.org/show_bug.cgi?id=72155

Attachment 114751: use native threading back-end
https://bugs.webkit.org/attachment.cgi?id=114751&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114751&action=review


Patch looks good to me! Except for the initialization bit (see comment below).
So r- just to clarify that, but otherwise nice cleanup! :)

> Source/WebKit/qt/Api/qwebsettings.cpp:311
> +    if (!global) {
> +	   WebCore::ScriptController::initializeThreading();
>	   global = new QWebSettings;
> +    }

Actually we call this already in QWebPagePagePrivate. Are you sure you need it
here?

If yes, then we should move all those initializations into a central function
that we can call from QWebPagePrivate as well as from here. I don't like the
idea of
sprinkling Foo::initializeBar() over the code :)