[webkit-reviews] review granted: [Bug 72161] [Qt][WK2] Implement loadHtml API for QQuickWebView : [Attachment 115365] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 72161: [Qt][WK2] Implement loadHtml API for QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=72161

Attachment 115365: Patch
https://bugs.webkit.org/attachment.cgi?id=115365&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115365&action=review


r=me

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:502
> +    The \a html is loaded immediately; external objects are loaded
asynchronously.

Hmm, how do we quantify immediately? It starts with an async message to the web
process :)

I'd rather leave that part out from the documentation tbh.