[webkit-reviews] review granted: [Bug 71997] crash: WebCore::FontPlatformData::roundsGlyphAdvances on Lion : [Attachment 115743] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Kenichi Ishibashi <bashi at chromium.org>'s request
for review:
Bug 71997: crash: WebCore::FontPlatformData::roundsGlyphAdvances on Lion
https://bugs.webkit.org/show_bug.cgi?id=71997

Attachment 115743: Patch
https://bugs.webkit.org/attachment.cgi?id=115743&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=115743&action=review


> Source/WebCore/ChangeLog:11
> +	   fontCache, but it could be null when the font is in fallback
> +	   list. Before looking up the fontCache, try to see whether the font

The reason a font from the fallback list might not be found in the font cache
is that it may be a web font.

> Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm:190
> +    U16_GET(cp, 0, 0, length, baseCharacter);

This didn’t have to move out of the if (fontData == systemFallbackFontData())
block, since baseCharacter is used only if we took that branch. But since this
initialization is not very expensive, it’s also okay to do it here.