[webkit-reviews] review denied: [Bug 71997] crash: WebCore::FontPlatformData::roundsGlyphAdvances on Lion : [Attachment 115082] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Kenichi Ishibashi <bashi at chromium.org>'s request for
review:
Bug 71997: crash: WebCore::FontPlatformData::roundsGlyphAdvances on Lion
https://bugs.webkit.org/show_bug.cgi?id=71997

Attachment 115082: Patch
https://bugs.webkit.org/attachment.cgi?id=115082&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=115082&action=review


Thanks for the patch! It’s good, but you should fix the base character issue.

> Source/WebCore/ChangeLog:8
> +	   Avoid setting invalid fontData to ComplexTextRun.

It would be nice to give a fuller description of what caused this bug and how
it’s addressed here.

> Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm:259
> +		       runFontData =
candidateFontData->fontDataForCharacter(runStartCharacter);

The purpose of this loop is to match against one of the fonts in the
WebCascadeList we’ve created, therefore we should be using the same character
used in the WebCascadeList (currently in the baseCharacter variable, which is
not in scope here), not the first character of the run.