[webkit-reviews] review granted: [Bug 72641] Appearance of compound transform animations under apps linked on SnowLeopard is incorrect : [Attachment 115715] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 17 20:08:03 PST 2011


Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 72641: Appearance of compound transform animations under apps linked on
SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641

Attachment 115715: Patch
https://bugs.webkit.org/attachment.cgi?id=115715&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115715&action=review


> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1748
> +#if !defined(BUILDING_ON_SNOW_LEOPARD) && !PLATFORM(WIN)
> +	   // Old versions of Core Animation apply animations in reverse order
(<rdar://problem/7095638>) so we need to flip the list.
>	   // to be non-additive. For binary compatibility, the current version
of Core Animation preserves this behavior for applications linked

Unless my diff decoding is faulty, you've got a "to be non-additive" empty
sentence there, or an extra period on the line before.


More information about the webkit-reviews mailing list