[webkit-reviews] review granted: [Bug 72551] When the recommended scrollbar style changes, WKView's tracking options should adjust accordingly : [Attachment 115454] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 17 17:47:38 PST 2011


Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 72551: When the recommended scrollbar style changes, WKView's tracking
options should adjust accordingly
https://bugs.webkit.org/show_bug.cgi?id=72551

Attachment 115454: Patch 
https://bugs.webkit.org/attachment.cgi?id=115454&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115454&action=review


> Source/WebCore/platform/ScrollView.cpp:966
> +void ScrollView::scrollbarStyleChanged(int newStyle, bool forceUpdate)
>  {
> +    UNUSED_PARAM(newStyle);

Normally we omit the argument name or comment it out rather than using
UNUSED_PARAM.

> Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp:677
> +void BuiltInPDFView::scrollbarStyleChanged(int newStyle, bool forceUpdate)
>  {
> +    UNUSED_PARAM(newStyle);

Same comment here.


More information about the webkit-reviews mailing list