[webkit-reviews] review granted: [Bug 72095] [chromium] Font::drawComplexText can not draw a segment of text run : [Attachment 115186] patch-v2

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Robin Cao
<robin.cao at torchmobile.com.cn>'s request for review:
Bug 72095: [chromium] Font::drawComplexText can not draw a segment of text run
https://bugs.webkit.org/show_bug.cgi?id=72095

Attachment 115186: patch-v2
https://bugs.webkit.org/attachment.cgi?id=115186&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115186&action=review


> Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp:548
> +void ComplexTextController::glyphsForRange(int from , int to, int&
fromGlyph, int& glyphLength)

nit: "from ," has an extra space.

>
LayoutTests/platform/chromium-linux/fast/text/international/draw-complex-text-f
rom-to.html:11
> +<p>The text and ellipsis should not overlap.</p>

Should this test be run on all ports?