[webkit-reviews] review denied: [Bug 72667] [Chromium] Fix broken DRT build for Aura Linux : [Attachment 115695] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 72667: [Chromium] Fix broken DRT build for Aura Linux
https://bugs.webkit.org/show_bug.cgi?id=72667

Attachment 115695: Patch
https://bugs.webkit.org/attachment.cgi?id=115695&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115695&action=review


> Tools/DumpRenderTree/chromium/TestShell.cpp:753
> +#if OS(LINUX) && !USE(GTK)

This looks like TestShellAndroid.cpp.  Here is my suggestion:

Make a TestShellLinux.cpp that has TestShell::waitTestFinished(),
AlarmHandler(int), and checkLayoutTestSystemDependencies().  These methods
appear to be the same everywhere.

Add a TestShellStub.cpp that has the other methods and use that on Android and
Aura.

Alternately, you could just make a TestShellAura.cpp that is basically the same
as TestShellAndroid.cpp with the belief that these will diverge over time.