[webkit-reviews] review granted: [Bug 72677] Remove more direct uses of os.path : [Attachment 115705] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 17 16:17:13 PST 2011


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 72677: Remove more direct uses of os.path
https://bugs.webkit.org/show_bug.cgi?id=72677

Attachment 115705: Patch
https://bugs.webkit.org/attachment.cgi?id=115705&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115705&action=review


> Tools/Scripts/webkitpy/common/config/committervalidator.py:43
> +	   (path, extension) = os.path.splitext(committers_path)

We should call filesystem.splitext.  The motivation is to have the tests work
the same way on Window and Linux.


More information about the webkit-reviews mailing list