[webkit-reviews] review denied: [Bug 72641] Appearance of compound transform animations under apps linked on SnowLeopard is incorrect : [Attachment 115650] Patch

[bugzilla-daemon at webkit.org]

Chris Marrin <cmarrin at apple.com> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 72641: Appearance of compound transform animations under apps linked on
SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641

Attachment 115650: Patch
https://bugs.webkit.org/attachment.cgi?id=115650&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115650&action=review


Generally looks good. But it needs at least a test that proves the ordering is
right. You should also check to make sure our additive animation tests are
sufficient, since you're making substantive changes to how you do additive.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1746
> +#if !defined(BUILDING_ON_SNOW_LEOPARD) && !PLATFORM(WIN)

So this is code is going to compile in on Leopard and then on Lion and above?