[webkit-reviews] review granted: [Bug 72342] Refactor SecurityOrigin::create to be easier to understand : [Attachment 115690] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 17 14:53:59 PST 2011
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 72342: Refactor SecurityOrigin::create to be easier to understand
https://bugs.webkit.org/show_bug.cgi?id=72342
Attachment 115690: Patch
https://bugs.webkit.org/attachment.cgi?id=115690&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115690&action=review
OK.
> Source/WebCore/page/SecurityOrigin.cpp:196
> + if (url.protocolIs("file")) {
> + // Unfortunately, we can't represent all unique origins exactly
> + // the same way because we need to produce a quirky database
> + // identifier for file URLs due to persistent storage in some
> + // embedders of WebKit.
> + origin->m_needsDatabaseIdentifierQuirkForFiles = true;
> + }
Can't we set this only for origins that matter to the database world?
More information about the webkit-reviews
mailing list