[webkit-reviews] review denied: [Bug 72632] [Chromium] Make GestureRecognizer Parameters Configurable (Incomplete - Seeking Feedback) : [Attachment 115619] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Eugene Girard
<girard at chromium.org>'s request for review:
Bug 72632: [Chromium] Make GestureRecognizer Parameters Configurable
(Incomplete - Seeking Feedback)
https://bugs.webkit.org/show_bug.cgi?id=72632

Attachment 115619: Patch
https://bugs.webkit.org/attachment.cgi?id=115619&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115619&action=review


> Source/WebKit/chromium/src/WebSettingsImpl.h:128
> +    virtual void setGestureParameters(const std::map<int,double>&);

hmm.. we don't have a good way of pasing a map across the webkit API boundary.
we've thus far avoided using std::map.	in this case, a simple structure with
five named fields would seem to be OK.	why not do that?