[webkit-reviews] review denied: [Bug 72513] [Qt] Test fonts are not used with Qt5 : [Attachment 115557] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 72513: [Qt] Test fonts are not used with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72513

Attachment 115557: Patch
https://bugs.webkit.org/attachment.cgi?id=115557&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Looks good, but I'm pretty sure this patch is going to break with Qt 4.8,
because Qt 4 doesn't support the configure tests. (r-)

However I think the solution is easy: For Qt 4 we make Qt DRT linux/x11 only
and just _assume_ (thus require) the presence of font-config, i.e. set the
define and pkgconfig if haveQt(4) in the .pro file (or the test passes with
qt5).