[webkit-reviews] review granted: [Bug 72319] [Qt] Support customizing JS alert/confirm/prompt dialogs using QML : [Attachment 115607] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 72319: [Qt] Support customizing JS alert/confirm/prompt dialogs using QML
https://bugs.webkit.org/show_bug.cgi?id=72319

Attachment 115607: Patch
https://bugs.webkit.org/attachment.cgi?id=115607&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115607&action=review


Great start :) Let's get the experiment in.

> Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h:118
> +    QScopedPointer<QDeclarativeComponent> alertDialog;
> +    QScopedPointer<QDeclarativeComponent> confirmDialog;
> +    QScopedPointer<QDeclarativeComponent> promptDialog;

Are you sure about the use of QScopedPointer here? In QDeclarative I see that
for example model delegates aren't stored with implied ownership transfer.