[webkit-reviews] review denied: [Bug 72153] Web Inspector: Application cache update/swapCache should be available from UI. : [Attachment 115585] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 17 08:40:43 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 72153: Web Inspector: Application cache update/swapCache should be
available from UI.
https://bugs.webkit.org/show_bug.cgi?id=72153

Attachment 115585: Patch
https://bugs.webkit.org/attachment.cgi?id=115585&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115585&action=review


> Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js:41
> +    this._updateButton.innerHTML = "↧";

.textContent = "\u21A7"; ? Please comment on the content of the symbol.

> Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js:47
> +    this._swapButton.innerHTML = "⇄";

ditto


More information about the webkit-reviews mailing list