[webkit-reviews] review granted: [Bug 72522] [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that : [Attachment 115552] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 17 03:27:47 PST 2011
Simon Hausmann <hausmann at webkit.org> has granted Tor Arne Vestbø
<vestbo at webkit.org>'s request for review:
Bug 72522: [Qt] Move WebKit2 C++ APIs to private API and build QML extension
plugin on top of that
https://bugs.webkit.org/show_bug.cgi?id=72522
Attachment 115552: Patch
https://bugs.webkit.org/attachment.cgi?id=115552&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115552&action=review
r=me but fix the coding style before landing :)
> Source/WebKit/qt/declarative/experimental/plugin.cpp:33
> + QQuickWebViewExperimentalExtension(QObject *parent = 0) :
QObject(parent) { }
> + QQuickWebViewExperimental* experimental() { return
static_cast<QQuickWebView*>(parent())->experimental(); }
Coding style: Move the braces onto lines of their own.
More information about the webkit-reviews
mailing list