[webkit-reviews] review denied: [Bug 72525] [GTK] Consider parent AtkObject in webkit_accessible_get_parent(), if already set : [Attachment 115411] Patch proposal + unit test

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 72525: [GTK] Consider parent AtkObject in webkit_accessible_get_parent(),
if already set
https://bugs.webkit.org/show_bug.cgi?id=72525

Attachment 115411: Patch proposal + unit test
https://bugs.webkit.org/attachment.cgi?id=115411&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115411&action=review


> Source/WebKit/gtk/tests/testatk.c:1669
> +    g_assert(atk_object_get_parent(axRoot) == axButton);

I think it would be useful to expand the test a bit:

- Add the view to an offscreen window. Get the parent. Should be the window.
- Now set_parent to the button, like you do now. Now get_parent should be the
button, not the window.

Hope that makes sense, that way we check the base case works and that the
transition happens correctly.

Looks good to me otherwise!