[webkit-reviews] review requested: [Bug 72312] DFG code blocks that have speculation checks on objects should refer to those objects weakly : [Attachment 115537] the patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 72312: DFG code blocks that have speculation checks on objects should refer
to those objects weakly
https://bugs.webkit.org/show_bug.cgi?id=72312

Attachment 115537: the patch
https://bugs.webkit.org/attachment.cgi?id=115537&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Fixed 32-bit build.  All tests pass, performance is neutral.  Verified with
printf's that the code was actually doing things; it was, and as expected: most
code blocks find all their weak references to be live on the first pass, and
all code blocks eventually always find all of their weak references to be live
in the benchmarks we track.  The latter is true mainly because we still treat
references from inline caches to be strong.