[webkit-reviews] review denied: [Bug 72479] Accessibility: Multiselect list boxes need to report focus in addition to selection : [Attachment 115529] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 72479: Accessibility: Multiselect list boxes need to report focus in
addition to selection
https://bugs.webkit.org/show_bug.cgi?id=72479

Attachment 115529: Patch
https://bugs.webkit.org/attachment.cgi?id=115529&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115529&action=review


> Source/WebCore/accessibility/AccessibilityListBoxOption.cpp:93
> +}

extra parens not needed

> Source/WebKit/chromium/src/WebAccessibilityObject.cpp:233
> +

for methods that return a bool, you should use true/false

> LayoutTests/accessibility/multiselect-list-reports-active-option.html:61
> +		   layoutTestController.notifyDone();

you need to remove the notificationListener from the object, otherwise
notifications can bleed into other tests