[webkit-reviews] review granted: [Bug 72577] Remove all custom constructors of Events from JSC : [Attachment 115525] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 16 22:31:54 PST 2011
Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 72577: Remove all custom constructors of Events from JSC
https://bugs.webkit.org/show_bug.cgi?id=72577
Attachment 115525: Patch
https://bugs.webkit.org/attachment.cgi?id=115525&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115525&action=review
> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3249
> + if (IsConstructorTemplate($dataNode, "Event")) {
I might have called IsConstructorTemplate something like
HasConstructorTemplate, but it's probably better to be consistent with the V8
code generator.
More information about the webkit-reviews
mailing list