[webkit-reviews] review requested: [Bug 70897] Use a simple page client for user consent in getUserMedia() : [Attachment 115493] Patch 6

[bugzilla-daemon at webkit.org]

Adam Bergkvist <adam.bergkvist at ericsson.com> has asked	for review:
Bug 70897: Use a simple page client for user consent in getUserMedia()
https://bugs.webkit.org/show_bug.cgi?id=70897

Attachment 115493: Patch 6
https://bugs.webkit.org/attachment.cgi?id=115493&action=review

------- Additional Comments from Adam Bergkvist <adam.bergkvist at ericsson.com>
(In reply to comment #34)
> (From update of attachment 115412 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=115412&action=review
> 
> I think we should land this patch so we can move forward.  This patch is
generally very good.  I have one memory-safety concern abou the lifetime of the
UserMediaClient, which I've noted below, but we can address that issue in a
follow-up patch.  Thanks again for iterating on this patch.
> 
> > Source/WebCore/mediastream/UserMediaRequest.cpp:105
> > +	 if (m_client) {
> > +	     m_client->cancelUserMediaRequest(this);
> > +	     m_client = 0;
> > +	 }
> 
> What is the lifetime of the UserMediaClient?	In particular, can a document
out-live the client?

Yes, there is a potential lifetime problem if the document can out-live the
page.

Small fixes in new patch:
* Removed early return on null-client in Navigator (caused test to fail; not
needed since the client is checked before used).
* Added functionality to be able to delete the UserMediaClient when the page is
destroyed.