[webkit-reviews] review granted: [Bug 72545] TextTrackList not sorted correctly : [Attachment 115451] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 72545: TextTrackList not sorted correctly
https://bugs.webkit.org/show_bug.cgi?id=72545

Attachment 115451: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=115451&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115451&action=review


> Source/WebCore/html/LoadableTextTrack.cpp:128
> +    for (Node* node = m_trackElement->parentNode()->firstChild(); node; node
= node->nextSibling()) {

What guarantees the track element has a non-zero parent?

> Source/WebCore/html/LoadableTextTrack.cpp:131
> +	   if (static_cast<HTMLTrackElement*>(node) == m_trackElement)

This cast shouldn’t be needed because m_trackElement should automatically
convert to a Node*.