[webkit-reviews] review granted: [Bug 72537] Add API for paginated display : [Attachment 115434] Add WebKit1 Mac SPI, WebKit2 Mac SPI and WebKit2 C SPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 16 15:56:22 PST 2011


Anders Carlsson <andersca at apple.com> has granted mitz at webkit.org's request for
review:
Bug 72537: Add API for paginated display
https://bugs.webkit.org/show_bug.cgi?id=72537

Attachment 115434: Add WebKit1 Mac SPI, WebKit2 Mac SPI and WebKit2 C SPI
https://bugs.webkit.org/attachment.cgi?id=115434&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115434&action=review


> Source/WebKit2/Shared/WebPageCreationParameters.cpp:49
> +    encoder->encode(paginationMode);

You can just use encodeEnum here.

> Source/WebKit2/Shared/WebPageCreationParameters.cpp:96
> +    if (!decoder->decode(parameters.paginationMode))
> +	   return false;

and decodeEnum here.


More information about the webkit-reviews mailing list