[webkit-reviews] review granted: [Bug 72452] [Chromium] Avoid clear and color mask operations for root layers : [Attachment 115453] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Daniel Sievers
<sievers at chromium.org>'s request for review:
Bug 72452: [Chromium] Avoid clear and color mask operations for root layers
https://bugs.webkit.org/show_bug.cgi?id=72452

Attachment 115453: Patch
https://bugs.webkit.org/attachment.cgi?id=115453&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115453&action=review


Daniel pointed out offline that he is eagerly initializing the non-swizzled
program and lazily initializing the swizzled one, which matches what we
currently do for other programs.

Could you please move removing the compositor blue clear to a separate patch?
We've had difficulties with that bit in particular and it's not inherently
related to the other changes.

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:397
> +#if !defined ( NDEBUG )

we tend to do #ifndef NDEBUG

> Source/WebCore/platform/graphics/chromium/ShaderChromium.h:185
> +    String getShaderString() const;

nit: this shouldn't have a "get" prefix, in WebKit style this function should
be called 'shaderString()'.  It looks like everything else in this file uses
the get prefix as well though.