[webkit-reviews] review granted: [Bug 72467] Code block jettisoning should be part of the GC's transitive closure : [Attachment 115333] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted  review:
Bug 72467: Code block jettisoning should be part of the GC's transitive closure
https://bugs.webkit.org/show_bug.cgi?id=72467

Attachment 115333: the patch
https://bugs.webkit.org/attachment.cgi?id=115333&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115333&action=review


r=me -- but make sure to check in the version that builds on Windows.

> Source/JavaScriptCore/bytecode/CodeBlock.h:1109
> +		   : isMarked(false)

Let's reserve the word "mark" for things with standard mark bits, and call this
"mightBeExecuting".

> Source/JavaScriptCore/heap/DFGCodeBlocks.cpp:46
> +    for (unsigned i = 0; i < toRemove.size(); ++i) {

You can use Vector's deleteAllValues here.

> Source/JavaScriptCore/heap/DFGCodeBlocks.cpp:85
> +    for (unsigned i = 0; i < toRemove.size(); ++i) {

Helper function here too.