[webkit-reviews] review denied: [Bug 68324] [Gtk] metaKey modifier is not working with eventSender object : [Attachment 107789] Patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied Devdatta Deshpande
<webkit.devdatta at gmail.com>'s request for review:
Bug 68324: [Gtk] metaKey modifier is not working with eventSender object
https://bugs.webkit.org/show_bug.cgi?id=68324

Attachment 107789: Patch
https://bugs.webkit.org/attachment.cgi?id=107789&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107789&action=review


Looks good overall, r- for a few small comments. Thanks for the patch!

> Tools/DumpRenderTree/gtk/EventSender.cpp:281
>      else if (JSStringIsEqualToUTF8CString(string, "metaKey"))

The indentation seems to be a bit screwed here?

> LayoutTests/ChangeLog:9
> +	   using evnetSender object.

s/evnet/event/

> LayoutTests/platform/gtk/fast/events/event-sender-metakey.html:13
> +	       return;

This seems a bit unnecessary? I'd just have metakey =false; <events with no
metakey>; metakey = true; <events with metakey>; and set failed to true if the
invariant breaks at any point?

> LayoutTests/platform/gtk/fast/events/event-sender-metakey.html:38
> +    resultDiv.innerHTML = (true == failed) ? "FAIL" : "PASS";

Simply failed?