[webkit-reviews] review granted: [Bug 70897] Use a simple page client for user consent in getUserMedia() : [Attachment 115412] Patch 5

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Adam Bergkvist
<adam.bergkvist at ericsson.com>'s request for review:
Bug 70897: Use a simple page client for user consent in getUserMedia()
https://bugs.webkit.org/show_bug.cgi?id=70897

Attachment 115412: Patch 5
https://bugs.webkit.org/attachment.cgi?id=115412&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115412&action=review


I think we should land this patch so we can move forward.  This patch is
generally very good.  I have one memory-safety concern abou the lifetime of the
UserMediaClient, which I've noted below, but we can address that issue in a
follow-up patch.  Thanks again for iterating on this patch.

> Source/WebCore/mediastream/UserMediaRequest.cpp:105
> +    if (m_client) {
> +	   m_client->cancelUserMediaRequest(this);
> +	   m_client = 0;
> +    }

What is the lifetime of the UserMediaClient?  In particular, can a document
out-live the client?