[webkit-reviews] review granted: [Bug 69219] [Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method: GET : [Attachment 115403] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 69219: [Soup] Somet tests fail with FAIL Unexpected response data received:
Wrong method: GET
https://bugs.webkit.org/show_bug.cgi?id=69219

Attachment 115403: Patch
https://bugs.webkit.org/attachment.cgi?id=115403&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115403&action=review


Thanks! addEncodedBlobToSoupMessageBody and addEncodedBlobItemToSoupMessageBody
now always return true. When landing please change their return type to void to
express that.

> LayoutTests/platform/gtk/Skipped:1536
> +# Fails because it does not throw a couple of expected exceptions

Might want to open a bug for this.