[webkit-reviews] review granted: [Bug 69123] [GTK] The process freezes when you right click on windowless Flash : [Attachment 112822] Fix build

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 69123: [GTK] The process freezes when you right click on windowless Flash
https://bugs.webkit.org/show_bug.cgi?id=69123

Attachment 112822: Fix build
https://bugs.webkit.org/attachment.cgi?id=112822&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112822&action=review


Looks good to me minus the nits.

> Source/WebKit2/ChangeLog:15
> +	   events while in windowed mode.

I think you mean windowless here.

> Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:187
> +#endif

If this only affects some versions of the plugin shouldn't you check for that?
Eg, if it's fixed in 11 or whatever, don't disable right click then.