[webkit-reviews] review denied: [Bug 71478] Fix up chromium API for creating events, initializing message events : [Attachment 115228] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 16 09:19:04 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Dave Michael
<dmichael at chromium.org>'s request for review:
Bug 71478: Fix up chromium API for creating events, initializing message events
https://bugs.webkit.org/show_bug.cgi?id=71478

Attachment 115228: Patch
https://bugs.webkit.org/attachment.cgi?id=115228&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115228&action=review


> Source/WebKit/chromium/ChangeLog:6
> +- Fix a mistake when checking the exception code during event creation.

nit: fix indentation here

> Source/WebKit/chromium/src/WebDOMMessageEvent.cpp:58
> +	   window =

nit: webkit style does not enforce line length limits, so this should just be
on one line.


More information about the webkit-reviews mailing list