[webkit-reviews] review denied: [Bug 72468] [WebKit2][gtk] Add few more properties to WebKitSettings : [Attachment 115347] Review comments incorporated

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 72468: [WebKit2][gtk] Add few more properties to WebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=72468

Attachment 115347: Review comments incorporated
https://bugs.webkit.org/attachment.cgi?id=115347&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115347&action=review


Loos fine to me other than some minor English nits.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:645
> +	* will disable maintaining history, cache, auto-fill information for
any

You can just remove "maintaining" here.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:660
> +	* Determines whether or not developer extras is enabled. This enables
> +	* developers to make use of debugging tools such as Web Inspector.

You might just replace this whole description and say "Determines whether or
not developer tools, such as the Web Inspector, are enabled.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:687
> +	* By enabling this setting, user will be able to focus the next element


By enabling this setting, user -> When this setting is enabled, users

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:689
> +	* then pressing tab key will insert tab character.

insert tab character -> insert the tab character

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp:179
> +    // Private browsing is disabled by default.
> +    g_assert(!webkit_settings_get_enable_private_browsing(settings));
> +    webkit_settings_set_enable_private_browsing(settings, TRUE);
> +    g_assert(webkit_settings_get_enable_private_browsing(settings));
> +
> +    // Developer extras is disabled by default.
> +    g_assert(!webkit_settings_get_enable_developer_extras(settings));
> +    webkit_settings_set_enable_developer_extras(settings, TRUE);
> +    g_assert(webkit_settings_get_enable_developer_extras(settings));
> +
> +    // Text areas are resizable by default.
> +    g_assert(webkit_settings_get_enable_resizable_text_areas(settings));
> +    webkit_settings_set_enable_resizable_text_areas(settings, FALSE);
> +    g_assert(!webkit_settings_get_enable_resizable_text_areas(settings));
> +
> +    // Tabs to link is disabled by default.
> +    g_assert(!webkit_settings_get_enable_tabs_to_links(settings));
> +    webkit_settings_set_enable_tabs_to_links(settings, TRUE);
> +    g_assert(webkit_settings_get_enable_tabs_to_links(settings));
> +

I think you can omit the comments. It should be clear from the code.