[webkit-reviews] review granted: [Bug 72373] Web Inspector: inspector follows javascript: hrefs as relative : [Attachment 115372] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 72373: Web Inspector: inspector follows javascript: hrefs as relative
https://bugs.webkit.org/show_bug.cgi?id=72373

Attachment 115372: Patch
https://bugs.webkit.org/attachment.cgi?id=115372&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115372&action=review


> Source/WebCore/inspector/front-end/ResourceUtils.js:291
> +	   if (href.indexOf("javascript:") === 0)

I'd rather do this check at the call site and return href here, otherwise looks
good.