[webkit-reviews] review granted: [Bug 72500] [GTK] Use a URI instead of local path to create download destination in WebKit2 : [Attachment 115371] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 72500: [GTK] Use a URI instead of local path to create download destination
in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72500

Attachment 115371: Patch
https://bugs.webkit.org/attachment.cgi?id=115371&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115371&action=review


Looks good! Maybe consider the following nit :)

> Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:69
> +	       downloadFailed(downloadDestinationError(response, _("Cannot
determine destination URI")));

What about mentioning the value of the suggestedFilename?