[webkit-reviews] review denied: [Bug 70407] [TexMap][QT] PageClientQt should skip redundant sync requests during Accelerated Composition. : [Attachment 115315] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 70407: [TexMap][QT] PageClientQt should skip redundant sync requests during
Accelerated Composition.
https://bugs.webkit.org/show_bug.cgi?id=70407

Attachment 115315: patch
https://bugs.webkit.org/attachment.cgi?id=115315&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115315&action=review


Almost there. I allowed myself to help reword the changelog entry, trying to
make it more concise and clear.

> Source/WebKit/qt/ChangeLog:12
> +	   It relieves the load of calling PageClientQWidget::syncLayers
redundantly.
> +	   It increases TexMap's performance when
PageClientQGraphicsWidget::markForSync is
> +	   called many times, especially the time to prepare layers and
animations.
> +	   The bug is actually that we rely on Timer::startOneShot to do
nothing if the
> +	   timer is already running, but the Timer fires same times that
> +	   Timer::startOneShot was called.

How about "Make sure we only activate the synchronization timer in
PageClientQWidget/PageClientQGraphicsWidget if it's not already active,
otherwise syncLayers may be called redundantly."