[webkit-reviews] review granted: [Bug 72455] QNX StackBase doesn't take guard page into account : [Attachment 115314] Add patch with changelog

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted George Staikos <staikos at kde.org>'s
request for review:
Bug 72455: QNX StackBase doesn't take guard page into account
https://bugs.webkit.org/show_bug.cgi?id=72455

Attachment 115314: Add patch with changelog
https://bugs.webkit.org/attachment.cgi?id=115314&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115314&action=review


Thanks for the patch!

> Source/JavaScriptCore/wtf/StackBounds.cpp:110
> +    m_bound = static_cast<char*>(stackBase) + 0x1000; // 4kb guard page

This is OK as-is. We should look to query the OS for the page size.