[webkit-reviews] review requested: [Bug 72423] [Chromium] Crash executing the WebGL conformance tests : [Attachment 115276] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 15 16:48:37 PST 2011


Jeff Timanus <twiz at chromium.org> has asked  for review:
Bug 72423: [Chromium]  Crash executing the WebGL conformance tests
https://bugs.webkit.org/show_bug.cgi?id=72423

Attachment 115276: Patch
https://bugs.webkit.org/attachment.cgi?id=115276&action=review

------- Additional Comments from Jeff Timanus <twiz at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115276&action=review


>> Source/WebCore/ChangeLog:4
>> +	    from attempting to stop a timer for a NULL context.
> 
> Does this need to be one line?

Done.

>> Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:131
>> +	// with the drawing buffer. If the drawing buffer is changing, make
sure
> 
> with with -> with

Thanks for catching that.

Done.


More information about the webkit-reviews mailing list