[webkit-reviews] review granted: [Bug 72423] [Chromium] Crash executing the WebGL conformance tests : [Attachment 115276] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted  review:
Bug 72423: [Chromium]  Crash executing the WebGL conformance tests
https://bugs.webkit.org/show_bug.cgi?id=72423

Attachment 115276: Patch
https://bugs.webkit.org/attachment.cgi?id=115276&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115276&action=review


Looks good to me; minor comment nit. Could you upload a final patch? Also, did
you get an email about what the style failure is? (Did you upload with
webkit-patch upload? That checks style before uploading.)

> Source/WebCore/ChangeLog:4
> +	   [chromium] During tear down, prevent the WebGLLayerChromium instance

> +	   from attempting to stop a timer for a NULL context.

Does this need to be one line?

> Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:131
> +    // The GraphicsContext3D used by the layer is the context associated
with
> +    // with the drawing buffer. If the drawing buffer is changing, make sure


with with -> with