[webkit-reviews] review granted: [Bug 72337] De-virtualize ExecutableBase::clearCodeVirtual : [Attachment 115268] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 15 16:04:25 PST 2011


Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 72337: De-virtualize ExecutableBase::clearCodeVirtual
https://bugs.webkit.org/show_bug.cgi?id=72337

Attachment 115268: Patch
https://bugs.webkit.org/attachment.cgi?id=115268&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115268&action=review


> Source/JavaScriptCore/runtime/Executable.cpp:90
> +    NativeExecutable* thisObject = jsCast<NativeExecutable*>(cell);
> +    thisObject->clearCode();

Not sure the local variable adds much.


More information about the webkit-reviews mailing list