[webkit-reviews] review granted: [Bug 72402] [chromium] Merge chromium-gpu layout test configurations into non-gpu versions : [Attachment 115263] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 72402: [chromium] Merge chromium-gpu layout test configurations into
non-gpu versions
https://bugs.webkit.org/show_bug.cgi?id=72402

Attachment 115263: Patch
https://bugs.webkit.org/attachment.cgi?id=115263&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115263&action=review


> Tools/ChangeLog:10
> +	   and video are still controlled by an explicit trigger so that they
are true when platform=chromium-gpu and false

Nit: maybe say "media" instead of video (or both) for people that aren't aware
that the two are synonymous?

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:431
> +	       'accelerated_video': '--enable-accelerated-video',

I think you need to change --accelerated-compositing to --accelerated-video in
run_webkit_tests.py as well (line220).