[webkit-reviews] review granted: [Bug 72390] [GTK] Do not hide accessibility root object from AT's : [Attachment 115174] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 15 14:57:50 PST 2011


Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 72390: [GTK] Do not hide accessibility root object from AT's
https://bugs.webkit.org/show_bug.cgi?id=72390

Attachment 115174: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=115174&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115174&action=review


> Source/WebKit/gtk/tests/testatk.c:85
> +	 return 0;
> +
> +    AtkObject* webAreaObject = atk_object_ref_accessible_child(rootObject,
0);
> +    if (!webAreaObject)
> +	 return 0;
> +

In C files you should use NULL instead of 0. (I realize this is incredibly
arbitrary, but the style guide specifies this!)


More information about the webkit-reviews mailing list