[webkit-reviews] review denied: [Bug 72178] Fix mixed content handling for AssociatedURLLoader. : [Attachment 114766] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Aaron Colwell
<acolwell at chromium.org>'s request for review:
Bug 72178: Fix mixed content handling for AssociatedURLLoader.
https://bugs.webkit.org/show_bug.cgi?id=72178

Attachment 114766: Patch
https://bugs.webkit.org/attachment.cgi?id=114766&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114766&action=review


We'll also need a test.

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:148
> +    if (!m_loader->checkIfDisplayInsecureContent(newRequest.url())) {
> +	   m_loader->cancel();
> +	   return;
> +    }

Don't we need all the checks from CachedResourceLoader::canRequest?  For
example, what if this load is forbidden for other reasons?