[webkit-reviews] review granted: [Bug 70754] implement flex-align for flex-flow: column : [Attachment 113001] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 70754: implement flex-align for flex-flow: column
https://bugs.webkit.org/show_bug.cgi?id=70754

Attachment 113001: Patch
https://bugs.webkit.org/attachment.cgi?id=113001&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113001&action=review


r=me

> Source/WebCore/rendering/RenderBox.cpp:1811
> +#if ENABLE(CSS3_FLEXBOX)
> +    if (parent()->isFlexibleBox())
> +	   return true;
> +#endif

Put a FIXME in here that the stretching children of vertical boxes will end up
doing an extra layout with this approach.