[webkit-reviews] review granted: [Bug 72378] [CSSShaders] Implement the style cached resources and computed style for the shader urls : [Attachment 115202] Patch V3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 15 12:07:58 PST 2011


Dean Jackson <dino at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 72378: [CSSShaders] Implement the style cached resources and computed style
for the shader urls
https://bugs.webkit.org/show_bug.cgi?id=72378

Attachment 115202: Patch V3
https://bugs.webkit.org/attachment.cgi?id=115202&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115202&action=review


> Source/WebCore/css/CSSStyleSelector.cpp:5519
> +		   operations.operations().append(operation);

Reading this line makes my head hurt :) I wonder if we should rename the
operations() accessor on FilterOperations. What do you think? (or we could put
the append method on FilterOperations)


More information about the webkit-reviews mailing list