[webkit-reviews] review denied: [Bug 64230] REGRESSION (r73385): Marquee with behavior="alternate" is not working : [Attachment 115125] Patch for Marquee-Behavior="alternate"

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Parag Radke
<nrqv63 at motorola.com>'s request for review:
Bug 64230: REGRESSION (r73385): Marquee with behavior="alternate" is not
working
https://bugs.webkit.org/show_bug.cgi?id=64230

Attachment 115125: Patch for Marquee-Behavior="alternate"
https://bugs.webkit.org/attachment.cgi?id=115125&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115125&action=review


Patch looks OK, but I'm not convinced that the test is good.

> LayoutTests/fast/html/marquee-alternate.html:5
> +	 It verifies marquee alternate behavior.For this test to pass, you
should see a the text should scroll to the left side extreem and than again
scroll back to the right. and it should keep on doing it.</p>

"extreem".

Is this test actually testing the bug fix? Wouldn't you have to wait for a
cycle of animation to really test things?