[webkit-reviews] review granted: [Bug 70471] Seaming on border corners with mixed colour alpha borders : [Attachment 115098] Patch with test

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ben Wells
<benwells at chromium.org>'s request for review:
Bug 70471: Seaming on border corners with mixed colour alpha borders
https://bugs.webkit.org/show_bug.cgi?id=70471

Attachment 115098: Patch with test
https://bugs.webkit.org/attachment.cgi?id=115098&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115098&action=review


> Source/WebCore/rendering/RenderBoxModelObject.cpp:1527
> +	   bool clipForStyle = styleRequiresClipPolygon(edgeToRender.style) &&
(mitreAdjacentSide1 || mitreAdjacentSide2);
> +	   bool clipAdjacentSide1 = colorNeedsAntiAliasAtCorner(side,
adjacentSide1, edges) && mitreAdjacentSide1;
> +	   bool clipAdjacentSide2 = colorNeedsAntiAliasAtCorner(side,
adjacentSide2, edges) && mitreAdjacentSide2;
> +	   bool shouldClip = clipForStyle || clipAdjacentSide1 ||
clipAdjacentSide2;

If you avoided the local variables, the test could short-circuit, which would
be slightly more efficient (if not quite as readable).

> LayoutTests/fast/borders/border-mixed-alpha.html:11
> +    div {
> +	   width: 20px;
> +	   height: 20px;
> +	   display: inline-block;
> +	   border-width: 40px;
> +	   border-color: rgba(0, 255, 0, 0.5);
> +	   border-right-color: rgba(0, 0, 255, 0.5);
> +    }
> +    .dashed { border-style: dashed; }

Can you make everything bigger here, so that the test fills the image (without
overflowing).