[webkit-reviews] review granted: [Bug 71149] Merge CachedResourceRequest and SubresourceLoader, delete SubresourceClient : [Attachment 114360] Fix chromium test failure + merge to trunk

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 71149: Merge CachedResourceRequest and SubresourceLoader, delete
SubresourceClient
https://bugs.webkit.org/show_bug.cgi?id=71149

Attachment 114360: Fix chromium test failure + merge to trunk
https://bugs.webkit.org/attachment.cgi?id=114360&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great.  A couple ideas for a follow-up patch:

1) Add some ASSERTS to the destructor that show we properly advance the state
machine to the end (and that documenting becomes null).
2) Use a member variable to track whether we've incremented/decremented the
request count to ensure we balance them properly (e.g., by ASSERTing in its
destructor that we've balanced).  That will also remove a bunch of multipart
related banches because we can tell this object to decrement the request count
if it hasn't already done so.