[webkit-reviews] review denied: [Bug 72331] Add the needed plumbing to parse display: -webkit-grid : [Attachment 115066] Proposed plumbing 1.

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 72331: Add the needed plumbing to parse display: -webkit-grid
https://bugs.webkit.org/show_bug.cgi?id=72331

Attachment 115066: Proposed plumbing 1.
https://bugs.webkit.org/attachment.cgi?id=115066&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115066&action=review


I think the style bot error is not related to your change.  r- for missing
Skipped file entries.

> Source/WebCore/rendering/style/RenderStyle.h:868
> +    void setDisplay(EDisplay v) { ASSERT(v >= INLINE && v <= NONE);
noninherited_flags._effectiveDisplay = v; }
> +    void setOriginalDisplay(EDisplay v) { ASSERT(v >= INLINE && v <= NONE);
noninherited_flags._originalDisplay = v; }

Isn't the assert redundant with the type checking done by the compiler?  As in,
if it's a valid number for EDisplay, it's between INLINE and NONE.

> LayoutTests/ChangeLog:15
> +	   * platform/chromium/test_expectations.txt:
> +	   SKIP the css-grid-layout tests for now.

Do we need to add fast/css-grid-layout to all the main (win/mac/gtk/qt) Skipped
files as well?